Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Add support for multiline selection #19

Merged
merged 2 commits into from
May 11, 2024

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Mar 9, 2024

  • add support for multiline selection for Github, Gitlab and Spaces
  • add support for column selection for Github

@lunakoly
Copy link
Owner

Sorry for the late response, I missed the notification :(, again. I'm not sure what's going on, because I do receive other notifications on GitHub quite frequently, and I did configure my mobile client to show me everything

@akhilerm
Copy link
Contributor Author

@lunakoly I have pushed the requested changes. PTAL. It took some time to really understand the sealed class concept and use the code snippet provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@lunakoly
Copy link
Owner

It took some time to really understand the sealed class concept and use the code snippet provided.

Took me some time to actually understand it

@akhilerm if you feel comfortable about it, I'd appreciate your sharing what confused you initially and what let you understand the idea :)

@akhilerm
Copy link
Contributor Author

@akhilerm if you feel comfortable about it, I'd appreciate your sharing what confused you initially and what let you understand the idea :)

Since I primarily work on Golang based projects, I was trying to map features from go -> kotlin to understand. But realized that it was a bad way to do it.

once i started to look from an object oriented perspective, it became clear. (Java -> Kotlin helped much more).

- add support for multiline selection for Github, Gitlab and Spaces
- add support for column selection for Github

Signed-off-by: Akhil Mohan <[email protected]>
@lunakoly
Copy link
Owner

That's interesting, because the pattern itself ("algebraic data types") doesn't come from OO :) sealed hierarchies are more of a way to limit OO to allow the compiler have more information (and if I remember correctly Kotlin had introduced them before Java did). But maybe Kotlin documentation is less clear than the Java one.

@lunakoly
Copy link
Owner

Oh, sorry, one more thing: you should probably bump the plugin version and add an entry to the changelog (and looks like for some reason publication of 1.0.7 didn't update the changelog automatically as it should have - not sure why). Please move the entries from "Unreleased" to 1.0.7, but add your note to "Unreleased": let's see if it'll work this time

@lunakoly lunakoly self-requested a review May 11, 2024 10:54
- add changelog
- update plugin version to 1.0.8

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm
Copy link
Contributor Author

That's interesting, because the pattern itself ("algebraic data types") doesn't come from OO :) sealed hierarchies are more of a way to limit OO to allow the compiler have more information (and if I remember correctly Kotlin had introduced them before Java did). But maybe Kotlin documentation is less clear than the Java one.

Oops. I will try to go through the docs once more to see what I got wrong.

@akhilerm
Copy link
Contributor Author

Updated the changelog and version to 1.0.8.

For 1.0.7 release, the github action run had failed. Unfortunately the logs are not available now to debug, since its 10 months old. Hope it will work this time 🤞

@lunakoly lunakoly merged commit 4318632 into lunakoly:main May 11, 2024
6 checks passed
@akhilerm akhilerm deleted the multiline-support branch May 12, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants