-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Add support for multiline selection #19
Conversation
akhilerm
commented
Mar 9, 2024
- add support for multiline selection for Github, Gitlab and Spaces
- add support for column selection for Github
src/main/kotlin/org/lunakoly/quicklink/urlbuilder/UrlBuilder.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/lunakoly/quicklink/urlbuilder/implementations/SpaceUrlBuilder.kt
Outdated
Show resolved
Hide resolved
Sorry for the late response, I missed the notification :(, again. I'm not sure what's going on, because I do receive other notifications on GitHub quite frequently, and I did configure my mobile client to show me everything |
@lunakoly I have pushed the requested changes. PTAL. It took some time to really understand the sealed class concept and use the code snippet provided. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
src/main/kotlin/org/lunakoly/quicklink/actions/CopyLineLinkAction.kt
Outdated
Show resolved
Hide resolved
@akhilerm if you feel comfortable about it, I'd appreciate your sharing what confused you initially and what let you understand the idea :) |
8901d6f
to
85faf4b
Compare
Since I primarily work on Golang based projects, I was trying to map features from go -> kotlin to understand. But realized that it was a bad way to do it. once i started to look from an object oriented perspective, it became clear. (Java -> Kotlin helped much more). |
- add support for multiline selection for Github, Gitlab and Spaces - add support for column selection for Github Signed-off-by: Akhil Mohan <[email protected]>
85faf4b
to
3aee28d
Compare
That's interesting, because the pattern itself ("algebraic data types") doesn't come from OO :) |
Oh, sorry, one more thing: you should probably bump the plugin version and add an entry to the changelog (and looks like for some reason publication of 1.0.7 didn't update the changelog automatically as it should have - not sure why). Please move the entries from "Unreleased" to 1.0.7, but add your note to "Unreleased": let's see if it'll work this time |
- add changelog - update plugin version to 1.0.8 Signed-off-by: Akhil Mohan <[email protected]>
Oops. I will try to go through the docs once more to see what I got wrong. |
Updated the changelog and version to 1.0.8. For 1.0.7 release, the github action run had failed. Unfortunately the logs are not available now to debug, since its 10 months old. Hope it will work this time 🤞 |